the major update to rsa-compat should have caused a major version update to greenlock #36

Закрито
відкрито 2019-04-27 10:00:42 +00:00 користувачем Ghost · 3 коментарів
Ghost прокоментував(ла) 2019-04-27 10:00:42 +00:00

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.
coolaj86 прокоментував(ла) 2019-04-27 15:03:53 +00:00
Власник

Can you tell me what broke so I can fix it?

Can you tell me what broke so I can fix it?
coolaj86 прокоментував(ла) 2019-04-27 15:05:05 +00:00
Власник

As far as I know there were no breaking changes.

The external dependencies were made explicit and that was it. Everything should still work with node v8.

As far as I know there were no breaking changes. The external dependencies were made explicit and that was it. Everything _should_ still work with node v8.
Ghost прокоментував(ла) 2019-04-27 16:39:19 +00:00
Author

our app used to work without the need for ursa. after a deployment it broke here. we found that ursa is now required for our app to work since we are on node < 10.

there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.

our app used to work without the need for `ursa`. after a deployment it broke [here](https://git.coolaj86.com/coolaj86/rsa-compat.js/src/branch/master/lib/generate-privkey.js#L55). we found that `ursa` is now required for our app to work since we are on node < 10. there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.
Ghost закрив цю задачу 2019-04-27 16:39:20 +00:00
Підпишіться щоб приєднатися до обговорення.
Без мітки
Етап відсутній
Немає виконавця
2 учасників
Сповіщення
Дата завершення
Термін дії не дійсний або знаходиться за межами допустимого діапазону. Будь ласка використовуйте формат 'yyyy-mm-dd'.

Термін виконання не встановлений.

Залежності

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#36
No description provided.