coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

greenlock 2.7.2 broke usage with "dynip domain names" #38

New Issue
Closed
opened 2019-05-14 07:02:19 +00:00 by Ghost · 3 comments
Ghost commented 2019-05-14 07:02:19 +00:00
Copy Link

We have reports from users from our project thet 2.7.2 of greenlock broke the usage with a external dynip domain. see https://github.com/ioBroker/ioBroker.js-controller/issues/372

In the commit of that I only saw that a check was changed from "domain" to "challenge.altname" ... maybe it has somehting to do with this?

Thank you for checking this issue.

Ingo

We have reports from users from our project thet 2.7.2 of greenlock broke the usage with a external dynip domain. see https://github.com/ioBroker/ioBroker.js-controller/issues/372 In the commit of that I only saw that a check was changed from "domain" to "challenge.altname" ... maybe it has somehting to do with this? Thank you for checking this issue. Ingo
coolaj86 commented 2019-05-14 08:30:57 +00:00
Owner
Copy Link

Can you give me a sample config and and the plugins that were being used?

I'm having difficulty reading the issue, but there should not be a breaking change and I want to fix the issue as soon as possible.

Can you give me a sample config and and the plugins that were being used? I'm having difficulty reading the issue, but there should not be a breaking change and I want to fix the issue as soon as possible.
coolaj86 referenced this issue from a commit 2019-11-01 11:10:12 +00:00
#38 passes create test
coolaj86 commented 2019-11-01 21:55:56 +00:00
Owner
Copy Link

Greenlock v3 is out and v2 is deprecated.

v3 has a much simpler set of challenge callbacks with a full test suite.

I'll put up a video on how to use it soon.

Greenlock v3 is out and v2 is deprecated. v3 has a much simpler set of challenge callbacks with a full test suite. I'll put up a video on how to use it soon.
Ghost commented 2019-11-01 23:03:32 +00:00
Author
Copy Link

cool to hear ...

cool to hear ...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jshaver coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#38
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?