coolaj86/greenlock.js-ARCHIVED
3
3
Atdalīts 0
Kods Problēmas 6 Izmaiņu pieprasījumi 1 Laidieni Aktivitāte

Consider monorepo / ECDSA Support #4

Jauna problēma
Slēgta
Ghost atvēra 2018-01-08 13:06:27 +00:00 · 4 komentāri
Ghost komentēja 2018-01-08 13:06:27 +00:00
Kopēt saiti

Currently, the family of greenlock packages are split across a dozen or so repos across different git hosting sites, each at different version. Links in docs are also constantly being broken.

This makes it very difficult to track what versions are actually in use, and very difficult to contribute things requiring coordination between different greenlock packages.

Considering switching the whole family of packages to a monorepo. This has all the benefits of having independently versioned modules, while still allowing easy coordination between them. Links in docs can also be relative to the repo instead of absolute to a git hosting site, which is apparently subject to changes every once in a while.

(P.S. I'd like to contribute ECDSA support, but I'm having a very hard time tracking the lower layers of greenlock, and figuring our what to contribute where, so at this point, I've given up before I've even made an attempt... Switching to a monorepo would help me A LOT)

Currently, the family of greenlock packages are split across a dozen or so repos across different git hosting sites, each at different version. Links in docs are also constantly being broken. This makes it very difficult to track what versions are actually in use, and very difficult to contribute things requiring coordination between different greenlock packages. Considering switching the whole family of packages to a [monorepo](https://github.com/babel/babel/blob/master/doc/design/monorepo.md). This has all the benefits of having independently versioned modules, while still allowing easy coordination between them. Links in docs can also be relative to the repo instead of absolute to a git hosting site, which is apparently subject to changes every once in a while. (P.S. I'd like to contribute ECDSA support, but I'm having a very hard time tracking the lower layers of greenlock, and figuring our what to contribute where, so at this point, I've given up before I've even made an attempt... Switching to a monorepo would help me A LOT)
coolaj86 komentēja 2018-01-12 02:40:29 +00:00
Īpašnieks
Kopēt saiti

Yeah... this repo has been an unfortunate victim of a lot of political nonsense. :-/

I agree in theory with the monorepo and have considered the approach before. The only problem is that npm doesn't support git subtrees and they have no plans to support it.

I can help you add ECDSA support. I'd love that.

Yeah... this repo has been an unfortunate victim of a lot of political nonsense. :-/ I agree in theory with the monorepo and have considered the approach before. The only problem is that npm doesn't support git subtrees and they have no plans to support it. I can help you add ECDSA support. I'd love that.
coolaj86 komentēja 2018-01-12 02:47:00 +00:00
Īpašnieks
Kopēt saiti

ECDSA key support needs to happen around here:

https://git.coolaj86.com/coolaj86/le-acme-core.js/src/master/lib/register-new-account.js#L12

And here:

https://git.coolaj86.com/coolaj86/le-acme-core.js/src/master/lib/acme-client.js#L15

And here:

https://git.coolaj86.com/coolaj86/greenlock.js/src/master/lib/core.js#L15

And there would need to be some sort of new option here:

https://git.coolaj86.com/coolaj86/greenlock.js/src/master/lib/core.js#L49

ECDSA key support needs to happen around here: ~~https://git.coolaj86.com/coolaj86/le-acme-core.js/src/master/lib/register-new-account.js#L12~~ And here: ~~https://git.coolaj86.com/coolaj86/le-acme-core.js/src/master/lib/acme-client.js#L15~~ And here: https://git.coolaj86.com/coolaj86/greenlock.js/src/master/lib/core.js#L15 And there would need to be some sort of new option here: https://git.coolaj86.com/coolaj86/greenlock.js/src/master/lib/core.js#L49
coolaj86 nomainīts nosaukums no Consider monorepo approach uz Consider monorepo approach / ECDSA Support 2018-04-19 20:12:05 +00:00
coolaj86 nomainīts nosaukums no Consider monorepo approach / ECDSA Support uz Consider monorepo / ECDSA Support 2018-04-19 20:12:16 +00:00
coolaj86 komentēja 2018-04-19 20:14:14 +00:00
Īpašnieks
Kopēt saiti

I've updated the API library for Let's Encrypt v2 (aka ACME v2 aka ACME draft 11)

https://git.coolaj86.com/coolaj86/acme-v2.js

That's the first place to start to add ECDSA support.

I've updated the API library for Let's Encrypt v2 (aka ACME v2 aka ACME draft 11) https://git.coolaj86.com/coolaj86/acme-v2.js That's the first place to start to add ECDSA support.
coolaj86 komentēja 2018-05-18 08:19:13 +00:00
Īpašnieks
Kopēt saiti

Closing as the feature is being worked on in the aforementioned repo, but making a note to update for those following when it's released.

Closing as the feature is being worked on in the aforementioned repo, but making a note to update for those following when it's released.
coolaj86 slēdza šo problēmu 2018-05-18 08:19:13 +00:00
Nepieciešams pieteikties, lai pievienotos šai sarunai.
Nav norādīts atzars/tags
Atzari Tagi
Iezīmes
Nav vienumu
Nav iezīmju
Atskaites punkts
Nav vienumu
Nav atskaites punktu
Atbildīgie
Noņemt atbildīgo
jshaver coolaj86
Nav atbildīgo
2 dalībnieki
Paziņojumi
Izpildes termiņš
Izpildes termiņš nav uzstādīts.
Atkarības

Nav atkarību.

Atsaucas uz: coolaj86/greenlock.js-ARCHIVED#4
Nav sniegts apraksts.
Dzēst atzaru "%!s()"

Atzara dzēšana ir neatgriezeniska. Kaut arī izdzēstais zars neilgu laiku var turpināt pastāvēt, pirms tas tiešām tiek noņemts, to vairumā gadījumu NEVAR atsaukt. Vai turpināt?