3
3

Function skipIfNeedBe in http-middleware.js should return a value #46

fechada(s)
2019-11-06 09:19:33 +00:00 aberta(s) por Ghost · 3 comentários

Hi AJ,

first of all, thank you for your awesome work!
Testing around with the new version of greenlock I stumbled across the following exception:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
node_modules/@root/greenlock-express/http-middleware.js:62:9

If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.

Hi AJ, first of all, thank you for your awesome work! Testing around with the new version of greenlock I stumbled across the following exception: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client node_modules/@root/greenlock-express/http-middleware.js:62:9 If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.
Autor(a)

I just realized, that I used the wrong repository to open the issue. Sorry for that!

I just realized, that I used the wrong repository to open the issue. Sorry for that!
Proprietário(a)

If you rm -rf node_modules and reinstall, I believe the problem was fixed yesterday:

https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js

If you `rm -rf node_modules` and reinstall, I believe the problem was fixed yesterday: https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js
Autor(a)

Yes, you are right. The new version does not have this issue. Thanks alot!

Yes, you are right. The new version does not have this issue. Thanks alot!
Ghost encerrou esta questão 2019-11-06 17:34:34 +00:00
Inicie a sessão para participar neste diálogo.
Sem rótulo
2 Participantes
Notificações
Data de vencimento
Sem data de vencimento definida.
Dependências

Não estão definidas dependências.

Referência: coolaj86/greenlock.js-ARCHIVED#46
Nenhuma descrição fornecida.