Function skipIfNeedBe in http-middleware.js should return a value #46
載入中…
x
新增問題並參考
Block a user
No description provided.
刪除分支「%!s()」
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi AJ,
first of all, thank you for your awesome work!
Testing around with the new version of greenlock I stumbled across the following exception:
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
node_modules/@root/greenlock-express/http-middleware.js:62:9
If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.
I just realized, that I used the wrong repository to open the issue. Sorry for that!
If you
rm -rf node_modulesand reinstall, I believe the problem was fixed yesterday:https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js
Yes, you are right. The new version does not have this issue. Thanks alot!