Function skipIfNeedBe in http-middleware.js should return a value #46

New Issue

Ghost · 2019-11-06T09:19:33Z

Ghost commented

2019-11-06 09:19:33 +00:00

Hi AJ,

first of all, thank you for your awesome work!
Testing around with the new version of greenlock I stumbled across the following exception:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
node_modules/@root/greenlock-express/http-middleware.js:62:9

If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.

Hi AJ, first of all, thank you for your awesome work! Testing around with the new version of greenlock I stumbled across the following exception: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client node_modules/@root/greenlock-express/http-middleware.js:62:9 If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.

Ghost commented

2019-11-06 09:21:41 +00:00

I just realized, that I used the wrong repository to open the issue. Sorry for that!

coolaj86 commented

2019-11-06 15:49:43 +00:00

If you rm -rf node_modules and reinstall, I believe the problem was fixed yesterday:

https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js

If you `rm -rf node_modules` and reinstall, I believe the problem was fixed yesterday: https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js

Ghost commented

2019-11-06 17:34:34 +00:00

Yes, you are right. The new version does not have this issue. Thanks alot!

Ghost closed this issue

2019-11-06 17:34:34 +00:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#46