Function skipIfNeedBe in http-middleware.js should return a value #46

已关闭
由 Ghost 于 2019-11-06 09:19:33 +00:00 打开 · 3 评论

Hi AJ,

first of all, thank you for your awesome work!
Testing around with the new version of greenlock I stumbled across the following exception:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
node_modules/@root/greenlock-express/http-middleware.js:62:9

If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.

Hi AJ, first of all, thank you for your awesome work! Testing around with the new version of greenlock I stumbled across the following exception: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client node_modules/@root/greenlock-express/http-middleware.js:62:9 If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.
作者

I just realized, that I used the wrong repository to open the issue. Sorry for that!

I just realized, that I used the wrong repository to open the issue. Sorry for that!
管理员

If you rm -rf node_modules and reinstall, I believe the problem was fixed yesterday:

https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js

If you `rm -rf node_modules` and reinstall, I believe the problem was fixed yesterday: https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js
作者

Yes, you are right. The new version does not have this issue. Thanks alot!

Yes, you are right. The new version does not have this issue. Thanks alot!
Ghost2019-11-06 17:34:34 +00:00 关闭此工单
登录 并参与到对话中。
未选择标签
2 名参与者
通知
到期时间
未设置到期时间。
依赖工单

没有设置依赖项。

参考:coolaj86/greenlock.js-ARCHIVED#46
没有提供说明。