coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

Function skipIfNeedBe in http-middleware.js should return a value #46

New Issue
Closed
opened 2019-11-06 09:19:33 +00:00 by Ghost · 3 comments
Ghost commented 2019-11-06 09:19:33 +00:00
Copy Link

Hi AJ,

first of all, thank you for your awesome work!
Testing around with the new version of greenlock I stumbled across the following exception:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
node_modules/@root/greenlock-express/http-middleware.js:62:9

If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.

Hi AJ, first of all, thank you for your awesome work! Testing around with the new version of greenlock I stumbled across the following exception: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client node_modules/@root/greenlock-express/http-middleware.js:62:9 If I understood your code correctly, I'd suggest to add a return value to the function skipIfNeedBe of http-middleware.js if the conditions are met.
Ghost commented 2019-11-06 09:21:41 +00:00
Author
Copy Link

I just realized, that I used the wrong repository to open the issue. Sorry for that!

I just realized, that I used the wrong repository to open the issue. Sorry for that!
coolaj86 commented 2019-11-06 15:49:43 +00:00
Owner
Copy Link

If you rm -rf node_modules and reinstall, I believe the problem was fixed yesterday:

https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js

If you `rm -rf node_modules` and reinstall, I believe the problem was fixed yesterday: https://git.coolaj86.com/coolaj86/greenlock-express.js/src/branch/master/http-middleware.js
Ghost commented 2019-11-06 17:34:34 +00:00
Author
Copy Link

Yes, you are right. The new version does not have this issue. Thanks alot!

Yes, you are right. The new version does not have this issue. Thanks alot!
Ghost closed this issue 2019-11-06 17:34:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jshaver coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#46
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?