coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

Setting directoryUrl doesn't work properly #57

New Issue
Open
opened 2021-04-09 13:13:07 +00:00 by Ghost · 1 comment
Ghost commented 2021-04-09 13:13:07 +00:00
Copy Link

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set.

To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it.

The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set. To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it. The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.
coolaj86 commented 2021-04-09 16:43:14 +00:00
Owner
Copy Link

Agreed.

Agreed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jshaver coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#57
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?