coolaj86/greenlock.js-ARCHIVED
3
3
Vork 0
Code Kwesties 6 Pull-aanvragen 1 Publicaties Activiteit

Setting directoryUrl doesn't work properly #57

Nieuw probleem
Open
2021-04-09 13:13:07 +00:00 geopend door Ghost · 1 comment
Ghost reageerde 2021-04-09 13:13:07 +00:00
Link kopiëren

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set.

To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it.

The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set. To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it. The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.
coolaj86 reageerde 2021-04-09 16:43:14 +00:00
Eigenaar
Link kopiëren

Agreed.

Agreed.
Log in om deel te nemen aan deze discussie.
Geen Branch/Tag gespecificeerd
Branches Labels
Labels
Geen items
Geen label
Mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Verwijder toegewezen aan
jshaver coolaj86
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
Geen vervaldatum ingesteld.
Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: coolaj86/greenlock.js-ARCHIVED#57
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?