coolaj86/greenlock.js-ARCHIVED
3
3
포크 0
코드 이슈 6 풀 리퀘스트 1 릴리즈 활동

Setting directoryUrl doesn't work properly #57

새로운 이슈
오픈
opened 2021-04-09 13:13:07 +00:00 by Ghost · 1 comment
Ghost 코멘트됨, 2021-04-09 13:13:07 +00:00
Copy Link

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set.

To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it.

The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set. To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it. The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.
coolaj86 코멘트됨, 2021-04-09 16:43:14 +00:00
소유자
Copy Link

Agreed.

Agreed.
"로그인하여 이 대화에 참여"
Branch/Tag 가 지정되어 있지 않습니다.
브랜치 태그
레이블
No items
레이블 없음
마일스톤
No items
마일스톤 없음
담당자
담당자 초기화
jshaver coolaj86
담당자 없음
참여자 2명
알림
마감일
마감일이 설정되지 않았습니다.
의존성

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#57
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?