wildcard support? #9

Nouveau ticket

Ghost · 2018-04-27T14:26:09Z

Ghost a commenté

2018-04-27 14:26:09 +00:00

.

I was getting invalid domain name error when doing *.example.com

I changed utils.js
from
var re = /^[a-zA-Z0-9.-]+$/;
to
var re = /^(*.)?[a-zA-Z0-9.-]+$/;

and the it worked :)

Let me know if I'm just completely missing something here though.

to support wildcards.

I was getting invalid domain name error when doing *.example.com I changed utils.js from var re = /^[a-zA-Z0-9\.\-]+$/; to var re = /^(\*\.)?[a-zA-Z0-9\.\-]+$/; and the it worked :) Let me know if I'm just completely missing something here though. to support wildcards.

coolaj86 a commenté

2018-04-27 15:26:30 +00:00

.

Propriétaire

Ah...

Good catch. I updated the underlying acme-v2.js, and had tested that, but I hadn't actually tested it in greenlock itself.

Thanks so much for the patch!

I really, really appreciate it.

I'll try to fit it in to get that published within a few hours.

:)

Ah... Good catch. I updated the underlying acme-v2.js, and had tested that, but I hadn't actually tested it in greenlock itself. Thanks so much for the patch! I really, really appreciate it. I'll try to fit it in to get that published within a few hours. :)

Ghost a commenté

2018-04-27 15:27:27 +00:00

.

Auteur

sweet :)

coolaj86 a commenté

2018-04-27 17:44:59 +00:00

.

Propriétaire

Hey m00ki3, Will you test v2.2.7?

This is the change that I made:

var re = /^(\*\.)?[a-zA-Z0-9\.\-]+$/;

> var re = /^(\*\.)?[a-zA-Z0-9\.\-]+$/;
undefined
> re.test('*.example.com')
true
> re.test('example.com')
true
> re.test('example.com.*')
false
> re.test('foobar!')
false

Hey `m00ki3`, Will you test v2.2.7? This is the change that I made: ```js var re = /^(\*\.)?[a-zA-Z0-9\.\-]+$/; ``` ``` > var re = /^(\*\.)?[a-zA-Z0-9\.\-]+$/; undefined > re.test('*.example.com') true > re.test('example.com') true > re.test('example.com.*') false > re.test('foobar!') false ```

coolaj86 a commenté

2018-04-27 17:45:37 +00:00

.

Propriétaire

At first I read your regex incorrectly because the \ were taken out... but makes sense now. :)

At first I read your regex incorrectly because the `\` were taken out... but makes sense now. :)

Ghost a commenté

2018-04-27 18:00:56 +00:00

.

Auteur

woo hoo! yup, works :)

coolaj86 a fermé ce ticket