v2.8.0: Fix regression with set challenges being ignored #40

Fusionado manualmente
coolaj86 fusionados 1 commits de dns-challenge-regression-fix en master hace 5 años
Propietario

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.
coolaj86 cerró este pull request hace 5 años
coolaj86 cambió el título de Fix regression with set challenges being ignored a v2.8.0: Fix regression with set challenges being ignored hace 5 años
coolaj86 referenció esta incidencia en un commit hace 5 años
El Pull Request se ha fusionado manualmente como c8b895633c.
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin etiquetas
Sin Milestone
No asignados
1 participantes
Notificaciones
Fecha de vencimiento

Sin fecha de vencimiento.

Dependencias

Este pull request actualmente no tiene ninguna dependencia.

Cargando…
Aún no existe contenido.