v2.8.0: Fix regression with set challenges being ignored #40

Fusionné manuellement
coolaj86 a fusionné 1 révision(s) à partir de dns-challenge-regression-fix vers master il y a 5 ans
coolaj86 a commenté il y a 5 ans
Propriétaire

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.
coolaj86 a fermé cette pull request il y a 5 ans
coolaj86 a modifié le titre de Fix regression with set challenges being ignored à v2.8.0: Fix regression with set challenges being ignored il y a 5 ans
coolaj86 a référencé ce ticket depuis une révision il y a 5 ans
La demande d'ajout a été fusionnée manuellement en tant que c8b895633c.
Connectez-vous pour rejoindre cette conversation.
Pas de relecteur
Pas d'étiquette
Aucun jalon
Pas d'assignataires
1 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

La demande de fusion n'a actuellement pas de dépendance.

Chargement…
Il n'existe pas encore de contenu.