Etiquetas Marcos

v2.8.0: Fix regression with set challenges being ignored #40

Manually merged

coolaj86 aplicou merge dos 1 commits de dns-challenge-regression-fix em master 5 anos atrás

Conversação 0 Commits 1 Arquivos alterados 4

coolaj86 comentou 5 anos atrás

Proprietário

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.

coolaj86 closed this pull request 5 anos atrás

coolaj86 alterou o título de Fix regression with set challenges being ignored para v2.8.0: Fix regression with set challenges being ignored 5 anos atrás

coolaj86 citou esta issue em um commit 5 anos atrás

Merge pull request #40 from Daplie/v2.x v2.x

The pull request has been manually merged as c8b895633c.

Acesse para participar desta conversação.

Revisores

Solicitar revisão

Sem revisor

Etiquetas

Aplicar etiquetas

Limpar etiquetas

Nenhum item

Sem etiqueta

Marco

Definir marco

Limpar marco

Nenhum item

Sem marco

Responsáveis

Atribuir usuários

Limpar responsáveis

Sem responsável

1 participante(s)

Notificações

Inscrever-se

Data limite

A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Atualmente este pull request não tem dependências.

Escrever Pré-visualização

Carregando…

Cancelar

Salvar

Ainda não há conteúdo.