v2.8.0: Fix regression with set challenges being ignored #40

Слито вручную
coolaj86 слито 1 коммит(ов) из dns-challenge-regression-fix в master 5 лет назад
coolaj86 прокомментировал 5 лет назад
Владелец

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.
coolaj86 закрыл этот запрос на слияние 5 лет назад
coolaj86 изменил заголовок с Fix regression with set challenges being ignored на v2.8.0: Fix regression with set challenges being ignored 5 лет назад
coolaj86 упомянул эту задачу в коммите 4 лет назад
Pull request был объединён вручную, как c8b895633c.
Войдите, чтобы присоединиться к обсуждению.
Нет рецензентов
Нет меток
Нет этапа
Нет назначенных лиц
1 участников
Уведомления
Срок выполнения

Срок выполнения не установлен.

Зависимости

Этот запрос на слияние в настоящее время не имеет никаких зависимостей.

Загрузка…
Пока нет содержимого.