lib/community.js

@@ -2,61 +2,47 @@
 
 function addCommunityMember(opts) {
   // { name, version, email, domains, action, communityMember, telemetry }
-  var https = require('https');
-  var req = https.request({
-    hostname: 'api.ppl.family'
-  , port: 443
-  , path: '/api/ppl.family/public/list'
-  , method: 'POST'
-  , headers: {
-      'Content-Type': 'application/json'
+  setTimeout(function () {
+    var https = require('https');
+    var req = https.request({
+      hostname: 'api.ppl.family'
+    , port: 443
+    , path: '/api/ppl.family/public/list'
+    , method: 'POST'
+    , headers: {
+        'Content-Type': 'application/json'
+      }
+    }, function (err, resp) {
+      if (err) { return; }
+      resp.on('data', function () {});
+    });
+    var os = require('os');
+    var data = {
+      address: opts.email
+      // greenlock-security is transactional and security only
+    , list: opts.communityMember ? (opts.name + '@ppl.family') : 'greenlock-security@ppl.family'
+    , action: opts.action // reg | renew
+    , package: opts.name
+      // hashed for privacy, but so we can still get some telemetry and inform users
+      // if abnormal things are happening (like several registrations for the same domain each day)
+    , domain: (opts.domains||[]).map(function (d) {
+        return require('crypto').createHash('sha1').update(d).digest('base64')
+          .replace(/\//g, '_').replace(/\+/g, '-').replace(/=/g, '');
+      }).join(',')
+    };
+    if (false !== opts.telemetry) {
+      data.arch = process.arch || os.arch();
+      data.platform = process.platform || os.platform();
+      data.release = os.release();
+      data.version = opts.version;
+      data.node = process.version;
     }
-  }, function (err, resp) {
-    if (err) { return; }
-    resp.on('data', function () {});
-  });
-  req.on('error', function(error) {
-    /* ignore */
-  });
-  var os = require('os');
-  var data = {
-    address: opts.email
-    // greenlock-security is transactional and security only
-  , list: opts.communityMember ? (opts.name + '@ppl.family') : 'greenlock-security@ppl.family'
-  , action: opts.action // reg | renew
-  , package: opts.name
-    // hashed for privacy, but so we can still get some telemetry and inform users
-    // if abnormal things are happening (like several registrations for the same domain each day)
-  , domain: (opts.domains||[]).map(function (d) {
-      return require('crypto').createHash('sha1').update(d).digest('base64')
-        .replace(/\//g, '_').replace(/\+/g, '-').replace(/=/g, '');
-    }).join(',')
-  };
-  if (false !== opts.telemetry) {
-    data.arch = process.arch || os.arch();
-    data.platform = process.platform || os.platform();
-    data.release = os.release();
-    data.version = opts.version;
-    data.node = process.version;
-  }
-  req.write(JSON.stringify(data, 2, null));
-  req.end();
+    req.write(JSON.stringify(data, 2, null));
+    req.end();
+  }, 50);
 }
 
-function delay(ms) {
-  return new Promise(function (resolve) {
-    return setTimeout(resolve, ms);
-  });
-}
-
-module.exports.add = function (opts) {
-  return delay(50).then(() => {
-    return addCommunityMember(opts);
-  })
-  .catch(function (ex) {
-    /* ignore */
-  })
-}
+module.exports.add = addCommunityMember;
 
 if (require.main === module) {
   //addCommunityMember('greenlock-express.js', 'reg', 'coolaj86+test42@gmail.com', ['coolaj86.com'], true);

lib/core.js

@@ -558,18 +558,20 @@ module.exports.create = function (gl) {
           if (!certs || !utils.certHasDomain(certs, args.domain)) {
             // There is no cert available
             if (false !== args.securityUpdates && !args._communityMemberAdded) {
-              // We will notify all greenlock users of mandatory and security updates
-              // We'll keep track of versions and os so we can make sure things work well
-              // { name, version, email, domains, action, communityMember, telemetry }
-              require('./community').add({
-                name: args._communityPackage
-              , version: args._communityPackageVersion
-              , email: args.email
-              , domains: args.domains || args.servernames
-              , action: 'reg'
-              , communityMember: args.communityMember
-              , telemetry: args.telemetry
-              });
+              try {
+                // We will notify all greenlock users of mandatory and security updates
+                // We'll keep track of versions and os so we can make sure things work well
+                // { name, version, email, domains, action, communityMember, telemetry }
+                require('./community').add({
+                  name: args._communityPackage
+                , version: args._communityPackageVersion
+                , email: args.email
+                , domains: args.domains || args.servernames
+                , action: 'reg'
+                , communityMember: args.communityMember
+                , telemetry: args.telemetry
+                });
+              } catch(e) { /* ignore */ }
               args._communityMemberAdded = true;
             }
             return core.certificates.registerAsync(args);
@@ -578,18 +580,20 @@ module.exports.create = function (gl) {
           if (core.certificates._isRenewable(args, certs)) {
             // it's time to renew the available cert
             if (false !== args.securityUpdates && !args._communityMemberAdded) {
-              // We will notify all greenlock users of mandatory and security updates
-              // We'll keep track of versions and os so we can make sure things work well
-              // { name, version, email, domains, action, communityMember, telemetry }
-              require('./community').add({
-                name: args._communityPackage
-              , version: args._communityPackageVersion
-              , email: args.email
-              , domains: args.domains || args.servernames
-              , action: 'renew'
-              , communityMember: args.communityMember
-              , telemetry: args.telemetry
-              });
+              try {
+                // We will notify all greenlock users of mandatory and security updates
+                // We'll keep track of versions and os so we can make sure things work well
+                // { name, version, email, domains, action, communityMember, telemetry }
+                require('./community').add({
+                  name: args._communityPackage
+                , version: args._communityPackageVersion
+                , email: args.email
+                , domains: args.domains || args.servernames
+                , action: 'renew'
+                , communityMember: args.communityMember
+                , telemetry: args.telemetry
+                });
+              } catch(e) { /* ignore */ }
               args._communityMemberAdded = true;
             }
             certs.renewing = core.certificates.renewAsync(args, certs);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "greenlock",
-  "version": "2.8.2",
+  "version": "2.8.1",
   "description": "Greenlock is Let's Encrypt (ACME) client for node.js",
   "homepage": "https://greenlock.domains/",
   "main": "index.js",