Compare commits

...

3 Commits

Author SHA1 Message Date
AJ ONeal f89f301a7c lucky version 2.2.16 2018-05-18 00:52:24 +00:00
AJ ONeal 672a659b70 tested new error logging 2018-05-18 00:51:44 +00:00
AJ ONeal da270686c0 better logging for approveDomains 2018-05-17 21:35:03 +00:00
2 changed files with 37 additions and 13 deletions

View File

@ -312,6 +312,9 @@ Greenlock.create = function (gl) {
if (!gl.approveDomains) {
gl.approvedDomains = gl.approvedDomains || [];
gl.approveDomains = function (lexOpts, certs, cb) {
var err;
var emsg;
if (!gl.email) {
throw new Error("le-sni-auto is not properly configured. Missing email");
}
@ -330,8 +333,12 @@ Greenlock.create = function (gl) {
lexOpts.communityMember = lexOpts.communityMember;
return cb(null, { options: lexOpts, certs: certs });
}
log(gl.debug, 'unapproved domain', lexOpts.domains, gl.approvedDomains);
cb(new Error("unapproved domain"));
emsg = "tls SNI for '" + lexOpts.domains.join(',') + "' rejected: not in list '" + gl.approvedDomains + "'";
log(gl.debug, emsg, lexOpts.domains, gl.approvedDomains);
err = new Error(emsg);
err.code = 'E_REJECT_SNI';
cb(err);
};
}
@ -343,7 +350,15 @@ Greenlock.create = function (gl) {
try {
gl.approveDomains(opts, certs, function (_err, results) {
if (_err) {
log(gl.debug, 'gl.approveDomains called with error', _err);
if (false !== gl.logRejectedDomains) {
console.error("[Error] approveDomains rejected tls sni '" + domain + "'");
console.error("[Error] (see https://git.coolaj86.com/coolaj86/greenlock.js/issues/11)");
if ('E_REJECT_SNI' !== _err.code) {
console.error("[Error] This is the rejection message:");
console.error(_err.message);
}
console.error("");
}
cb(_err);
return;
}
@ -351,21 +366,30 @@ Greenlock.create = function (gl) {
log(gl.debug, 'gl.approveDomains called with certs for', results.certs && results.certs.altnames || 'NONE', 'and options:');
log(gl.debug, results.options);
var promise;
if (results.certs) {
log(gl.debug, 'gl renewing');
promise = gl.core.certificates.renewAsync(results.options, results.certs);
return gl.core.certificates.renewAsync(results.options, results.certs).then(
function (certs) { cb(null, certs); }
, function (e) {
console.debug("Error renewing certificate for '" + domain + "':");
console.debug(e);
console.error("");
cb(e);
}
);;
}
else {
log(gl.debug, 'gl getting from disk or registering new');
promise = gl.core.certificates.getAsync(results.options);
return gl.core.certificates.getAsync(results.options).then(
function (certs) { cb(null, certs); }
, function (e) {
console.debug("Error loading/registering certificate for '" + domain + "':");
console.debug(e);
console.error("");
cb(e);
}
);
}
return promise.then(function (certs) { cb(null, certs); }, function (e) {
if (gl.debug) { console.debug("Error"); console.debug(e); }
cb(e);
});
});
} catch(e) {
console.error("[ERROR] Something went wrong in approveDomains:");

View File

@ -1,6 +1,6 @@
{
"name": "greenlock",
"version": "2.2.15",
"version": "2.2.16",
"description": "Let's Encrypt for node.js on npm",
"main": "index.js",
"scripts": {