le-store-SPEC.js says that email is optional in setKeypair #2

New Issue

Ghost · 2018-10-24T19:18:02Z

Ghost commented

2018-10-24 19:18:02 +00:00

Readme suggests that email will always be provided in setKeypair but the template branch says that opts.email is optional.

In addition, the in-memory implementation validates that an email has been provided.

Which is correct?

Given that a valid email needs to be provided with a domain that has a valid MX record, this suggests that email is mandatory

Readme suggests that email will always be provided in setKeypair but the template branch says that opts.email is optional. In addition, the in-memory implementation validates that an email has been provided. Which is correct? Given that a valid email needs to be provided with a domain that has a valid MX record, this suggests that email is mandatory

coolaj86 commented

2018-10-24 20:30:47 +00:00

Registration

Technically the email is optional according to the ACME protocol spec.

However, changing the current implementation of Greenlock to make that true is probably not worth the effort.

Registration vs Renewal

You may write an implementation in which you can look up what you need to by using other information (such as the domain itself, or cert or key thumbprint) without the email.

In this sense, the email is still optional for a renewal, even though it is required for registration.

In fact, someone may not have the email available at the time of renewal because in their implementation they may need to look up the email address based on the domain.

Registration ===== Technically the email is optional according to the ACME protocol spec. However, changing the current implementation of Greenlock to make that true is probably not worth the effort. Registration vs Renewal ===== You may write an implementation in which you can look up what you need to by using other information (such as the domain itself, or cert or key thumbprint) without the email. In this sense, the email is still optional for a renewal, even though it is required for registration. In fact, someone may not have the email available at the time of renewal because in their implementation they may need to look up the email address based on the domain.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/le-store-SPEC.js#2