coolaj86
/
le-store-SPEC.js
1
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

Should there be a package.json in this project? #3

New Issue
Open
opened 2018-10-24 19:18:33 +00:00 by Ghost · 4 comments
Ghost commented 2018-10-24 19:18:33 +00:00
Copy Link

There doesn't seem to be a package.json file in the template.

There doesn't seem to be a package.json file in the template.
coolaj86 commented 2018-10-24 20:33:09 +00:00
Owner
Copy Link

Yeah, that sounds like a good idea.

I've been meaning to document my own process of creating a template, but since I always use the first one I created I just never got around to it.

That said, I'd be happy to help you and perhaps beef up the docs in the process.

Yeah, that sounds like a good idea. I've been meaning to document my own process of creating a template, but since I always use the first one I created I just never got around to it. That said, I'd be happy to help you and perhaps beef up the docs in the process.
Ghost commented 2018-10-24 22:06:34 +00:00
Author
Copy Link

Hey AJ,

Thanks for that. I am currently using the le-store-redis package.json as a template.

I'm writing a mongo le-store-* currently. Forgive me but it's been a while since I used promises versus async/await. Do you know how I set up async connections to db before returning the spec? I need to wait for creation of the connection and the collection to be returned before any of the members of the create() function will work

Your in memory implementation doesn't use the JSON web tokens - is that because of the security of creating an id from the jwk or because generally the PEM is sufficient and always provided?

thanks

Chanoch

Hey AJ, Thanks for that. I am currently using the le-store-redis package.json as a template. I'm writing a mongo le-store-* currently. Forgive me but it's been a while since I used promises versus async/await. Do you know how I set up async connections to db before returning the spec? I need to wait for creation of the connection and the collection to be returned before any of the members of the create() function will work Your in memory implementation doesn't use the JSON web tokens - is that because of the security of creating an id from the jwk or because generally the PEM is sufficient and always provided? thanks Chanoch
Ghost commented 2018-10-25 08:56:28 +00:00
Author
Copy Link

Sorry, I found the le-store-mongo that you forked on github (it was 404 on your gitea - the link which is on your list of plugins)

I am now in the process of updating it to the 3 driver...

Sorry, I found the le-store-mongo that you forked on github (it was 404 on your gitea - the link which is on your list of plugins) I am now in the process of updating it to the 3 driver...
Ghost commented 2018-10-25 09:12:19 +00:00
Author
Copy Link

I am guessing that the person who wrote the original code didn't get the tests working hence they were 'commented' out in package.json using the echo "1" && process.exit(-1) line.

It looks like the account tests are working because there's enough of a delay to let the database complete the insertion of accounts before later tests check for their existence but the certificates do not.

Could you point me at an explanation for how the latest certificate for a given domain or email is returned? I can't find a test for it but it would appear that there is a need to add a date to the record and then sort by reverse creation date?

thanks

I am guessing that the person who wrote the original code didn't get the tests working hence they were 'commented' out in package.json using the echo "1" && process.exit(-1) line. It looks like the account tests are working because there's enough of a delay to let the database complete the insertion of accounts before later tests check for their existence but the certificates do not. Could you point me at an explanation for how the latest certificate for a given domain or email is returned? I can't find a test for it but it would appear that there is a need to add a date to the record and then sort by reverse creation date? thanks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
template
tests
readme
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/le-store-SPEC.js#3
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?