coolaj86/rsa-compat.js
1
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

ursa-optional error handling not working #3

New Issue
Closed
opened 2018-12-28 06:17:05 +00:00 by Ghost · 2 comments
Ghost commented 2018-12-28 06:17:05 +00:00
Copy Link

In 'generate-privkey.js', the following code has been written to provide a fallback if ursa fails to build:

 try {
    return require('./generate-privkey-node.js')(bitlen, exp);
  } catch(e) {
    if (!/generateKeyPairSync is not a function/.test(e.message)) {
      throw e;
    }
    try {
      return require('./generate-privkey-ursa.js')(bitlen, exp);
    } catch(e) {
      if (e.code !== 'MODULE_NOT_FOUND') {
        throw e;
      }
      if (!oldver) {
        oldver = true;
        console.warn("[WARN] rsa-compat: Your version of node does not have crypto.generateKeyPair()");
        console.warn("[WARN] rsa-compat: Please update to node >= v10.12 or 'npm install ursa'");
        console.warn("[WARN] rsa-compat: Using node-forge as a fallback, but it may be unacceptably slow.");

However, due to the check if (e.code !== 'MODULE_NOT_FOUND'), this code fails to fall back to forge in the event that the module "installs" but dosen't "build". I am not well versed enough in ursa to even know if that should be possible, but it has given me hell this evening, as the result is a cryptic error and a stalled server. Commenting out that check caused the module to fallback on forge and work as expected.

In 'generate-privkey.js', the following code has been written to provide a fallback if ursa fails to build: ``` try { return require('./generate-privkey-node.js')(bitlen, exp); } catch(e) { if (!/generateKeyPairSync is not a function/.test(e.message)) { throw e; } try { return require('./generate-privkey-ursa.js')(bitlen, exp); } catch(e) { if (e.code !== 'MODULE_NOT_FOUND') { throw e; } if (!oldver) { oldver = true; console.warn("[WARN] rsa-compat: Your version of node does not have crypto.generateKeyPair()"); console.warn("[WARN] rsa-compat: Please update to node >= v10.12 or 'npm install ursa'"); console.warn("[WARN] rsa-compat: Using node-forge as a fallback, but it may be unacceptably slow."); ``` However, due to the check `if (e.code !== 'MODULE_NOT_FOUND')`, this code fails to fall back to forge in the event that the module "installs" but dosen't "build". I am not well versed enough in ursa to even know if that should be possible, but it has given me hell this evening, as the result is a cryptic error and a stalled server. Commenting out that check caused the module to fallback on forge and work as expected.
coolaj86 commented 2018-12-28 15:38:05 +00:00
Owner
Copy Link

Thanks for the report. That is a very strange condition.

Can you copy/paste the cryptic error message to me or give me a summary of what it said?

Thanks for the report. That is a very strange condition. Can you copy/paste the cryptic error message to me or give me a summary of what it said?
coolaj86 commented 2019-03-13 15:39:32 +00:00
Owner
Copy Link

Closing due to inactivity.

Closing due to inactivity.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/rsa-compat.js#3
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?