install_helper doesn't handle group names with spaces #40

New Issue

Ghost · 2020-02-07T18:00:33Z

Ghost commented

2020-02-07 18:00:33 +00:00

For example, my group is something like "MYDOMAIN\Domain Users" (out of my control). When it attempts to chown the files, it fails:

chown: MYDOMAIN\Domain: illegal group name

I believe it's because the group (and username) are not being guarded when used in install_helper.sh:

chown $(id -u -n):$(id -g -n) ...

For example, my group is something like "MYDOMAIN\Domain Users" (out of my control). When it attempts to `chown` the files, it fails: ``` chown: MYDOMAIN\Domain: illegal group name ``` I believe it's because the group (and username) are not being guarded when used in `install_helper.sh`: ``` chown $(id -u -n):$(id -g -n) ... ```

coolaj86 commented

2020-05-03 00:48:41 +00:00

That is unfortunate.

I will accept a PR if you want to find out where those places are and add quotes or escapes or whatever it needs to be.

That is unfortunate. I will accept a PR if you want to find out where those places are and add quotes or escapes or whatever it needs to be.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/telebit.js#40