better param parsing #36

Merged
coolaj86 merged 1 commits from params-parsing into master 2019-05-29 21:38:17 +00:00
Owner

Removing any and all of the following leading characters before parsing the params: #/?.

  • #access_token=x&foo=bar => access_token=x&foo=bar
  • #/?access_token=x&foo=bar => access_token=x&foo=bar
  • #/access_token=x&foo=bar => access_token=x&foo=bar
  • #?access_token=x&foo=bar => access_token=x&foo=bar
Removing any and all of the following leading characters before parsing the params: `#/?`. * `#access_token=x&foo=bar` => `access_token=x&foo=bar` * `#/?access_token=x&foo=bar` => `access_token=x&foo=bar` * `#/access_token=x&foo=bar` => `access_token=x&foo=bar` * `#?access_token=x&foo=bar` => `access_token=x&foo=bar`
Ghost approved these changes 2019-05-29 01:49:48 +00:00
@ -4,3 +4,3 @@
document.body.hidden = false;
var hash = window.location.hash.substr(1);
var hash = window.location.hash.replace(/^[\/#?]+/, '');
First-time contributor

Would #? to be safe, but I think inside a square bracket it's fine.

Would \#\? to be safe, but I think inside a square bracket it's fine.
Author
Owner

true on both accounts

true on both accounts
coolaj86 closed this pull request 2019-05-29 21:38:17 +00:00
Author
Owner

Thanks @mikegwhit

Thanks @mikegwhit
Sign in to join this conversation.
No reviewers
No Label
feature
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/telebit.js#36
No description provided.