coolaj86
/
telebit.js
1
2
Forka 1
Codice Problemi 46 Pull Requests 2 Rilasci Attività

better param parsing #36

Unito
coolaj86 ha unito 1 commit da params-parsing a master 2019-05-29 21:38:17 +00:00
Conversazione 1 Commit 1 File modificati 1 +1 -1
coolaj86 2019-05-28 23:09:55 +00:00 ha commentato
Proprietario
Copia link

Removing any and all of the following leading characters before parsing the params: #/?.

  • #access_token=x&foo=bar => access_token=x&foo=bar
  • #/?access_token=x&foo=bar => access_token=x&foo=bar
  • #/access_token=x&foo=bar => access_token=x&foo=bar
  • #?access_token=x&foo=bar => access_token=x&foo=bar
Removing any and all of the following leading characters before parsing the params: `#/?`. * `#access_token=x&foo=bar` => `access_token=x&foo=bar` * `#/?access_token=x&foo=bar` => `access_token=x&foo=bar` * `#/access_token=x&foo=bar` => `access_token=x&foo=bar` * `#?access_token=x&foo=bar` => `access_token=x&foo=bar`
Ghost hanno approvato queste modifiche 2019-05-29 01:49:48 +00:00
lib/html/js/app.js
@ -4,3 +4,3 @@
document.body.hidden = false;
var hash = window.location.hash.substr(1);
var hash = window.location.hash.replace(/^[\/#?]+/, '');
Ghost 2019-05-29 01:49:42 +00:00 ha commentato
First-time contributor
Copia link

Would #? to be safe, but I think inside a square bracket it's fine.

Would \#\? to be safe, but I think inside a square bracket it's fine.
coolaj86 2019-05-29 21:38:30 +00:00 ha commentato
Autore
Proprietario
Copia link

true on both accounts

true on both accounts
coolaj86 chiusa questa pull request 2019-05-29 21:38:17 +00:00
coolaj86 2019-05-31 22:19:49 +00:00 ha commentato
Autore
Proprietario
Copia link

Thanks @mikegwhit

Thanks @mikegwhit
Effettua l'accesso per partecipare alla conversazione.
Revisori
Nessun revisore
Etichette
Pulisci le etichette   
feature

something new that would be great to add

Nessuna etichetta
feature
Traguardo
Milestone pulita
Nessun elemento
Nessuna milestone
Assegnatari
Cancella assegnatari
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/telebit.js#36
No description provided.
Delete Branch "params-parsing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?