better param parsing #36

coolaj86 · 2019-05-28T23:09:55Z

coolaj86 komentēja

2019-05-28 23:09:55 +00:00

Īpašnieks

Removing any and all of the following leading characters before parsing the params: #/?.

#access_token=x&foo=bar => access_token=x&foo=bar
#/?access_token=x&foo=bar => access_token=x&foo=bar
#/access_token=x&foo=bar => access_token=x&foo=bar
#?access_token=x&foo=bar => access_token=x&foo=bar

Removing any and all of the following leading characters before parsing the params: `#/?`. * `#access_token=x&foo=bar` => `access_token=x&foo=bar` * `#/?access_token=x&foo=bar` => `access_token=x&foo=bar` * `#/access_token=x&foo=bar` => `access_token=x&foo=bar` * `#?access_token=x&foo=bar` => `access_token=x&foo=bar`

Ghost apstiprināja izmaiņas 2019-05-29 01:49:48 +00:00

lib/html/js/app.js

						
				@ -4,3 +4,3 @@

				document.body.hidden = false;

				var hash = window.location.hash.substr(1);

				var hash = window.location.hash.replace(/^[\/#?]+/, '');

Ghost komentēja

2019-05-29 01:49:42 +00:00

First-time contributor

Would #? to be safe, but I think inside a square bracket it's fine.

Would \#\? to be safe, but I think inside a square bracket it's fine.

coolaj86 komentēja

2019-05-29 21:38:30 +00:00

Autors

Īpašnieks

true on both accounts

coolaj86 aizvēra šo izmaiņu pieprasījumu

2019-05-29 21:38:17 +00:00

coolaj86 komentēja

2019-05-31 22:19:49 +00:00

Autors

Īpašnieks

Thanks @mikegwhit

Pierakstieties, lai pievienotos šai sarunai.

Nav recenzentu

Nav etiķešu

feature

Nav atskaites punktu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Atsaucas uz: coolaj86/telebit.js#36