Allow to use unibabel.hex as a ES6 module #1

Ghost · 2019-02-01T14:19:55Z

Ghost comentou

2019-02-01 14:19:55 +00:00

Primeira vez contribuindo

This PR makes unibabel.hex to be used as a module.
unibabel.hex can be used like: import { Unibabel } from 'unibabel/unibabel.hex.js';

This PR makes unibabel.hex to be used as a module. unibabel.hex can be used like: `import { Unibabel } from 'unibabel/unibabel.hex.js';`

coolaj86 reviewed 2019-04-17 14:18:31 +00:00

coolaj86 deixou um comentário

Proprietário

Loo

coolaj86 comentou

2019-04-17 14:23:05 +00:00

Proprietário

I'm just seeing this now.

It looks like this breaks browser compatibility.

I think this should fix it, would you mind testing?

-var _index = require('./index.js');
-
-
-
-var Unibabel = _interopRequireWildcard(_index).Unibabel;
-
-
-
-function _interopRequireWildcard(obj) {
-
-  if (obj && obj.__esModule) {
-
-    return obj;
-
-  } else {
-
-    var newObj = {};
-
-    if (obj != null) {
-
-      for (var key in obj) {
-
-        if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key];
-
-      }
-
-    }
-
-    newObj.default = obj;
-
-    return newObj;
-
-  }
-
-}

To:

var Unibabel = exports.Unibabel || require('./index.js').Unibabel;

It really sucks that there are so many JavaScript-knockoff languages and frameworks that don't maintain compatibility with JavaScript and expect you to break compatibility or add lots of boilerplate to get them to work with The Real McCoy.

I'm just seeing this now. It looks like this breaks browser compatibility. I think this should fix it, would you mind testing? ```js -var _index = require('./index.js'); - - - -var Unibabel = _interopRequireWildcard(_index).Unibabel; - - - -function _interopRequireWildcard(obj) { - - if (obj && obj.__esModule) { - - return obj; - - } else { - - var newObj = {}; - - if (obj != null) { - - for (var key in obj) { - - if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key]; - - } - - } - - newObj.default = obj; - - return newObj; - - } - -} ``` To: ```js var Unibabel = exports.Unibabel || require('./index.js').Unibabel; ``` It really sucks that there are so many JavaScript-knockoff languages and frameworks that don't maintain compatibility with JavaScript and expect you to break compatibility or add lots of boilerplate to get them to work with The Real McCoy.

Este pull request tem alterações conflitantes com o branch de destino.

package.json

Acesse para participar desta conversação.

2 participante(s)

Notificações

Data limite

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: coolaj86/unibabel.js#1