Allow to use unibabel.hex as a ES6 module #1

開放中

Ghost 請求將 1 次程式碼提交從 (deleted):master 合併至 master

拉取自: (deleted):master

合併到: coolaj86:master

coolaj86:master

coolaj86:v3

對話內容 2 程式碼提交 1 檔案變動 2 +26 -5

Ghost 已留言 2019-02-01 14:19:55 +00:00

First-time contributor

複製連結

This PR makes unibabel.hex to be used as a module.
unibabel.hex can be used like: import { Unibabel } from 'unibabel/unibabel.hex.js';

This PR makes unibabel.hex to be used as a module. unibabel.hex can be used like: `import { Unibabel } from 'unibabel/unibabel.hex.js';`

coolaj86 reviewed 2019-04-17 14:18:31 +00:00

coolaj86 留下了回應

擁有者

複製連結

Loo

Loo

coolaj86 已留言 2019-04-17 14:23:05 +00:00

擁有者

複製連結

I'm just seeing this now.

It looks like this breaks browser compatibility.

I think this should fix it, would you mind testing?

-var _index = require('./index.js');
-
-
-
-var Unibabel = _interopRequireWildcard(_index).Unibabel;
-
-
-
-function _interopRequireWildcard(obj) {
-
-  if (obj && obj.__esModule) {
-
-    return obj;
-
-  } else {
-
-    var newObj = {};
-
-    if (obj != null) {
-
-      for (var key in obj) {
-
-        if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key];
-
-      }
-
-    }
-
-    newObj.default = obj;
-
-    return newObj;
-
-  }
-
-}

To:

var Unibabel = exports.Unibabel || require('./index.js').Unibabel;

It really sucks that there are so many JavaScript-knockoff languages and frameworks that don't maintain compatibility with JavaScript and expect you to break compatibility or add lots of boilerplate to get them to work with The Real McCoy.

I'm just seeing this now. It looks like this breaks browser compatibility. I think this should fix it, would you mind testing? ```js -var _index = require('./index.js'); - - - -var Unibabel = _interopRequireWildcard(_index).Unibabel; - - - -function _interopRequireWildcard(obj) { - - if (obj && obj.__esModule) { - - return obj; - - } else { - - var newObj = {}; - - if (obj != null) { - - for (var key in obj) { - - if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key]; - - } - - } - - newObj.default = obj; - - return newObj; - - } - -} ``` To: ```js var Unibabel = exports.Unibabel || require('./index.js').Unibabel; ``` It really sucks that there are so many JavaScript-knockoff languages and frameworks that don't maintain compatibility with JavaScript and expect you to break compatibility or add lots of boilerplate to get them to work with The Real McCoy.

此合併請求有變更和目標分支衝突。

• package.json

登入 才能加入這對話。

審核者

No Reviewers

標籤

沒有項目

未選擇標籤

里程碑

沒有項目

未選擇里程碑

負責人

清除負責人

jshaver coolaj86

沒有負責人

2 參與者

通知

訂閱

截止日期

未設定截止日期。

先決條件

未設定先決條件。

參考: coolaj86/unibabel.js#1

No description provided.