From ef5dcb81f4c7c5cc58e93c58027804d1ff827470 Mon Sep 17 00:00:00 2001 From: tigerbot Date: Fri, 3 Nov 2017 14:36:27 -0600 Subject: [PATCH] fixed bug determining for which domains to set new DNS records --- lib/ddns/dns-ctrl.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/ddns/dns-ctrl.js b/lib/ddns/dns-ctrl.js index 2c8912b..59eee35 100644 --- a/lib/ddns/dns-ctrl.js +++ b/lib/ddns/dns-ctrl.js @@ -108,7 +108,7 @@ module.exports.create = function (deps, conf) { return record.value === addr && badAddrDomains.indexOf(record.host) < 0; }).map(record => record.host); var requiredUpdates = domains.filter(function (domain) { - return goodAddrDomains.indexOf(domain) !== -1; + return goodAddrDomains.indexOf(domain) < 0; }); var oldDns = await splitDomains(directives.api, badAddrDomains); @@ -120,6 +120,9 @@ module.exports.create = function (deps, conf) { await deps.PromiseA.all(oldDns.map(function (record) { return deps.OAUTH3.api(directives.api, Object.assign({}, common, record)); })); + if (conf.debug && badAddrDomains.length) { + console.log('removed bad DNS records for ' + badAddrDomains.join(', ')); + } var newDns = await splitDomains(directives.api, requiredUpdates); common = { @@ -132,6 +135,9 @@ module.exports.create = function (deps, conf) { await deps.PromiseA.all(newDns.map(function (record) { return deps.OAUTH3.api(directives.api, Object.assign({}, common, record)); })); + if (conf.debug && requiredUpdates.length) { + console.log('set new DNS records for ' + requiredUpdates.join(', ')); + } } async function getDeviceAddresses(session) {