coolaj86
/
acme-dns-01-namecheap.js
1
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

bug fixes #2

Closed
Ghost wants to merge 3 commits from fixes into master
pull from: fixes
merge into: coolaj86:master
Conversation 1 Commits 3 Files Changed 3 +299 -249
Ghost commented 2019-07-23 06:02:55 +00:00
First-time contributor
Copy Link

Fixed these bugs:

  1. Incorrectly get zone
  2. SLD/TLD incorrectly derived
Fixed these bugs: 1. Incorrectly get zone 2. SLD/TLD incorrectly derived
coolaj86 commented 2019-07-23 08:26:45 +00:00
Owner
Copy Link

Red herring.

This was the problem: 705902ff32

dnsZone should always be correct. If that's not correct, the problem is in zones().

Red herring. This was the problem: https://git.coolaj86.com/coolaj86/acme-dns-01-namecheap.js/commit/705902ff32b6e46dd7cf40437d5c8751119eeede `dnsZone` should _always_ be correct. If that's not correct, the problem is in `zones()`.
coolaj86 closed this pull request 2019-07-23 08:26:50 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme-dns-01-namecheap.js#2
No description provided.
Delete Branch "fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?