coolaj86
/
acme.js-ARCHIVED
2
1
Fork 0
Code Issues 4 Pull Requests 3 Releases Activity

Handle unnaceptable nonce values #27

Closed
Ghost wants to merge 0 commits from (deleted):retry-badnonce-getcert into master
pull from: (deleted):retry-badnonce-getcert
merge into: coolaj86:master
Conversation 1 Commits - Files Changed 80 +2443 -5532
Ghost commented 2019-07-29 10:31:21 +00:00
First-time contributor
Copy Link

Like with the badNonce issue discussed in #17 - I am still encountering nonce value issues as of greenlock@2.8.2 and acme-v2@1.8.2.

I have not been able to determine the root cause, but retrying on a bad nonce seems to take care of the failure symptom so here is a patch for those annoying cases where it gets stuck on a domain.

[acme-v2] handled(?) rejection as errback:
Error: [acme-v2.js] authorizations were not fetched for '{{domain}}':
{"type":"urn:ietf:params:acme:error:badNonce","detail":"JWS has an invalid anti-replay nonce: \"{{nonce}}\"","status":400}   
    at /var/www/brand/node_modules/acme-v2/node.js:1180:10
    at process._tickCallback (internal/process/next_tick.js:68:7)

[acme-v2] handled(?) rejection as errback:
Error: Didn't finalize order: Unhandled status '400'. This is not one of the known statuses...
Requested: '{{domain}}'
Validated: '{{domain}}'
{
  "type": "urn:ietf:params:acme:error:badNonce",
  "detail": "JWS has no anti-replay nonce",
  "status": 400
}
Please open an issue at https://git.coolaj86.com/coolaj86/acme-v2.js
    at /var/www/brand/node_modules/acme-v2/node.js:1005:6
    at process._tickCallback (internal/process/next_tick.js:68:7)
Like with the `badNonce` issue discussed in #17 - I am still encountering nonce value issues as of `greenlock@2.8.2` and `acme-v2@1.8.2`. I have not been able to determine the root cause, but retrying on a bad nonce seems to take care of the failure symptom so here is a patch for those annoying cases where it gets stuck on a domain. ``` [acme-v2] handled(?) rejection as errback: Error: [acme-v2.js] authorizations were not fetched for '{{domain}}': {"type":"urn:ietf:params:acme:error:badNonce","detail":"JWS has an invalid anti-replay nonce: \"{{nonce}}\"","status":400} at /var/www/brand/node_modules/acme-v2/node.js:1180:10 at process._tickCallback (internal/process/next_tick.js:68:7) ``` ``` [acme-v2] handled(?) rejection as errback: Error: Didn't finalize order: Unhandled status '400'. This is not one of the known statuses... Requested: '{{domain}}' Validated: '{{domain}}' { "type": "urn:ietf:params:acme:error:badNonce", "detail": "JWS has no anti-replay nonce", "status": 400 } Please open an issue at https://git.coolaj86.com/coolaj86/acme-v2.js at /var/www/brand/node_modules/acme-v2/node.js:1005:6 at process._tickCallback (internal/process/next_tick.js:68:7) ```
Ghost closed this pull request 2020-02-14 00:22:18 +00:00
Ghost commented 2020-02-14 00:22:32 +00:00
Author
First-time contributor
Copy Link

Closing as abandoned.

Closing as abandoned.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme.js-ARCHIVED#27
No description provided.
Delete Branch "(deleted):retry-badnonce-getcert"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?