Handle unnaceptable nonce values #27

Ghost · 2019-07-29T10:31:21Z

Ghost がコメント

2019-07-29 10:31:21 +00:00

初めての貢献者

Like with the badNonce issue discussed in #17 - I am still encountering nonce value issues as of greenlock@2.8.2 and acme-v2@1.8.2.

I have not been able to determine the root cause, but retrying on a bad nonce seems to take care of the failure symptom so here is a patch for those annoying cases where it gets stuck on a domain.

[acme-v2] handled(?) rejection as errback:
Error: [acme-v2.js] authorizations were not fetched for '{{domain}}':
{"type":"urn:ietf:params:acme:error:badNonce","detail":"JWS has an invalid anti-replay nonce: \"{{nonce}}\"","status":400}   
    at /var/www/brand/node_modules/acme-v2/node.js:1180:10
    at process._tickCallback (internal/process/next_tick.js:68:7)

[acme-v2] handled(?) rejection as errback:
Error: Didn't finalize order: Unhandled status '400'. This is not one of the known statuses...
Requested: '{{domain}}'
Validated: '{{domain}}'
{
  "type": "urn:ietf:params:acme:error:badNonce",
  "detail": "JWS has no anti-replay nonce",
  "status": 400
}
Please open an issue at https://git.coolaj86.com/coolaj86/acme-v2.js
    at /var/www/brand/node_modules/acme-v2/node.js:1005:6
    at process._tickCallback (internal/process/next_tick.js:68:7)

Like with the `badNonce` issue discussed in #17 - I am still encountering nonce value issues as of `greenlock@2.8.2` and `acme-v2@1.8.2`. I have not been able to determine the root cause, but retrying on a bad nonce seems to take care of the failure symptom so here is a patch for those annoying cases where it gets stuck on a domain. ``` [acme-v2] handled(?) rejection as errback: Error: [acme-v2.js] authorizations were not fetched for '{{domain}}': {"type":"urn:ietf:params:acme:error:badNonce","detail":"JWS has an invalid anti-replay nonce: \"{{nonce}}\"","status":400} at /var/www/brand/node_modules/acme-v2/node.js:1180:10 at process._tickCallback (internal/process/next_tick.js:68:7) ``` ``` [acme-v2] handled(?) rejection as errback: Error: Didn't finalize order: Unhandled status '400'. This is not one of the known statuses... Requested: '{{domain}}' Validated: '{{domain}}' { "type": "urn:ietf:params:acme:error:badNonce", "detail": "JWS has no anti-replay nonce", "status": 400 } Please open an issue at https://git.coolaj86.com/coolaj86/acme-v2.js at /var/www/brand/node_modules/acme-v2/node.js:1005:6 at process._tickCallback (internal/process/next_tick.js:68:7) ```

Ghost がプルリクエストをクローズ

2020-02-14 00:22:18 +00:00

Ghost がコメント

2020-02-14 00:22:32 +00:00

作成者

初めての貢献者

Closing as abandoned.

プルリクエストはクローズされました

このプルリクエストはブランチが削除されているため、再オープンできません。

サインインしてこの会話に参加。

1 人の参加者

通知

期日

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: coolaj86/acme.js-ARCHIVED#27