error handling when service is on down or in maintenance #28

Ghost · 2019-12-04T18:10:39Z

Ghost commented

2019-12-04 18:10:39 +00:00

First-time contributor

Hi there,

I was receiving this response for a short period of time:

{
   type: 'urn:acme:error:serverInternal',
   detail: 'The service is down for maintenance or had an internal error. Check https://letsencrypt.status.io/ for more details.'
}

As there are no error handling for this section, the error that was actually showing up before me digging on the sources was this:

Error cert_order:
Cannot read property 'termsOfService' of undefined
TypeError: Cannot read property 'termsOfService' of undefined
    at fin (/root/raftwars/source/node_modules/@root/acme/acme.js:75:23)
    at /root/raftwars/source/node_modules/@root/acme/acme.js:96:12
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Hi there, I was receiving this response for a short period of time: ``` { type: 'urn:acme:error:serverInternal', detail: 'The service is down for maintenance or had an internal error. Check https://letsencrypt.status.io/ for more details.' } ``` As there are no error handling for this section, the error that was actually showing up before me digging on the sources was this: ``` Error cert_order: Cannot read property 'termsOfService' of undefined TypeError: Cannot read property 'termsOfService' of undefined at fin (/root/raftwars/source/node_modules/@root/acme/acme.js:75:23) at /root/raftwars/source/node_modules/@root/acme/acme.js:96:12 at processTicksAndRejections (internal/process/task_queues.js:93:5) ```

This pull request has changes conflicting with the target branch.

acme.js

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme.js-ARCHIVED#28