error handling when service is on down or in maintenance #28

Aperto
Ghost vorrebbe unire 1 commit da (deleted):master a master
First-time contributor

Hi there,

I was receiving this response for a short period of time:

{
   type: 'urn:acme:error:serverInternal',
   detail: 'The service is down for maintenance or had an internal error. Check https://letsencrypt.status.io/ for more details.'
}

As there are no error handling for this section, the error that was actually showing up before me digging on the sources was this:

Error cert_order:
Cannot read property 'termsOfService' of undefined
TypeError: Cannot read property 'termsOfService' of undefined
    at fin (/root/raftwars/source/node_modules/@root/acme/acme.js:75:23)
    at /root/raftwars/source/node_modules/@root/acme/acme.js:96:12
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Hi there, I was receiving this response for a short period of time: ``` { type: 'urn:acme:error:serverInternal', detail: 'The service is down for maintenance or had an internal error. Check https://letsencrypt.status.io/ for more details.' } ``` As there are no error handling for this section, the error that was actually showing up before me digging on the sources was this: ``` Error cert_order: Cannot read property 'termsOfService' of undefined TypeError: Cannot read property 'termsOfService' of undefined at fin (/root/raftwars/source/node_modules/@root/acme/acme.js:75:23) at /root/raftwars/source/node_modules/@root/acme/acme.js:96:12 at processTicksAndRejections (internal/process/task_queues.js:93:5) ```
Questa pull request ha modifiche in conflitto con il branch di destinazione.
  • acme.js
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna etichetta
Nessuna milestone
Nessuna assegnatario
1 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/acme.js-ARCHIVED#28
No description provided.