coolaj86
/
asn1.js
1
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

comment out console.error #1

Open
Ghost wants to merge 1 commits from (deleted):no-console-error into master
pull from: (deleted):no-console-error
merge into: coolaj86:master
Conversation 1 Commits 1 Files Changed 5 +11 -11
Ghost commented 2020-06-06 14:33:54 +00:00
First-time contributor
Copy Link

I have been using @root/asn1 to parse the ASN.1 structure of ECDSA signature.
My unit test includes a scenario that tries to verify a corrupted signature, but I found this library is printing to the console.
https://travis-ci.com/github/yoursunny/NDNts/jobs/344524703#L1093-L1139

Corrupted signatures could occur in real applications too.
This commit comments out this debug statement, to keep the console clean.

I have been using `@root/asn1` to parse the ASN.1 structure of ECDSA signature. My unit test includes a scenario that tries to verify a corrupted signature, but I found this library is printing to the console. https://travis-ci.com/github/yoursunny/NDNts/jobs/344524703#L1093-L1139 Corrupted signatures could occur in real applications too. This commit comments out this debug statement, to keep the console clean.
coolaj86 commented 2024-08-30 19:55:18 +00:00
Owner
Copy Link

This is in at https://github.com/therootcompany/asn1.js

I need to go back and make this repo to be a pull mirror.

This is in at https://github.com/therootcompany/asn1.js I need to go back and make this repo to be a pull mirror.
This pull request is broken due to missing fork information.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/asn1.js#1
No description provided.
Delete Branch "(deleted):no-console-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?