coolaj86
/
bluecrypt-keypairs.js
1
1
Fork 1
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

no-acme #10

Merged
lastlink merged 13 commits from lastlink/bluecrypt-keypairs.js:no-acme into master 5 years ago
Conversation 0 Commits 13 Files Changed 3
lastlink commented 5 years ago
Collaborator
  • fixed merge issue
  • jwk to jwt & jws
* fixed merge issue * jwk to jwt & jws
coolaj86 approved these changes 5 years ago
coolaj86 left a comment

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?

app.js
kty: $('input[name="kty"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
, modulusLength: $('input[name="rsa-len"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
coolaj86 commented 5 years ago
Poster
Owner

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.
app.js
$('.js-generate').hidden = false;
$('.js-sign').hidden = false;
$('textarea[name="jwk"]').value = JSON.stringify({
coolaj86 commented 5 years ago
Poster
Owner

What's this hard-coded value for?

What's this hard-coded value for?
lastlink closed this pull request 5 years ago
The pull request has been merged as 93e939e517.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'lastlink/bluecrypt-keypairs.js:no-acme'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes