no-acme #10

Merged
lastlink merged 13 commits from lastlink/bluecrypt-keypairs.js:no-acme into master 2019-05-11 22:32:00 +00:00
Collaborator
  • fixed merge issue
  • jwk to jwt & jws
* fixed merge issue * jwk to jwt & jws
coolaj86 approved these changes 2019-05-11 21:58:39 +00:00
coolaj86 left a comment
Owner

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?
@ -52,3 +54,2 @@
kty: $('input[name="kty"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
, modulusLength: $('input[name="rsa-len"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
Owner

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.
@ -112,1 +166,4 @@
$('.js-generate').hidden = false;
$('.js-sign').hidden = false;
$('textarea[name="jwk"]').value = JSON.stringify({
Owner

What's this hard-coded value for?

What's this hard-coded value for?
lastlink closed this pull request 2019-05-11 22:32:00 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/bluecrypt-keypairs.js#10
No description provided.