no-acme #10

Unito
lastlink ha unito 13 commit da lastlink/bluecrypt-keypairs.js:no-acme a master 2019-05-11 22:32:00 +00:00
Collaborator
  • fixed merge issue
  • jwk to jwt & jws
* fixed merge issue * jwk to jwt & jws
coolaj86 hanno approvato queste modifiche 2019-05-11 21:58:39 +00:00
coolaj86 lascia un commento
Proprietario

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?
@ -52,3 +54,2 @@
kty: $('input[name="kty"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
, modulusLength: $('input[name="rsa-len"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
Proprietario

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.
@ -112,1 +166,4 @@
$('.js-generate').hidden = false;
$('.js-sign').hidden = false;
$('textarea[name="jwk"]').value = JSON.stringify({
Proprietario

What's this hard-coded value for?

What's this hard-coded value for?
lastlink chiusa questa pull request 2019-05-11 22:32:00 +00:00
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna etichetta
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/bluecrypt-keypairs.js#10
No description provided.