no-acme #10

병합
lastlink lastlink/bluecrypt-keypairs.js:no-acme 에서 master 로 13 commits 를 머지했습니다 2019-05-11 22:32:00 +00:00
Collaborator
  • fixed merge issue
  • jwk to jwt & jws
* fixed merge issue * jwk to jwt & jws
coolaj86 이 변경사항을 승인하였습니다. 2019-05-11 21:58:39 +00:00
coolaj86 left a comment
소유자

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?
@ -52,3 +54,2 @@
kty: $('input[name="kty"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
, modulusLength: $('input[name="rsa-len"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
소유자

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.
@ -112,1 +166,4 @@
$('.js-generate').hidden = false;
$('.js-sign').hidden = false;
$('textarea[name="jwk"]').value = JSON.stringify({
소유자

What's this hard-coded value for?

What's this hard-coded value for?
lastlink closed this pull request 2019-05-11 22:32:00 +00:00
"로그인하여 이 대화에 참여"
No reviewers
레이블 없음
마일스톤 없음
담당자 없음
참여자 2명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: coolaj86/bluecrypt-keypairs.js#10
No description provided.