no-acme #10

Sammanfogat
lastlink sammanfogade 13 incheckningar från lastlink/bluecrypt-keypairs.js:no-acme in i master 2019-05-11 22:32:00 +00:00
Collaborator
  • fixed merge issue
  • jwk to jwt & jws
* fixed merge issue * jwk to jwt & jws
coolaj86 godkände dessa ändringar 2019-05-11 21:58:39 +00:00
coolaj86 lämnade en kommentar
Ägare

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?
@ -52,3 +54,2 @@
kty: $('input[name="kty"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
, modulusLength: $('input[name="rsa-len"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
Ägare

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.
@ -112,1 +166,4 @@
$('.js-generate').hidden = false;
$('.js-sign').hidden = false;
$('textarea[name="jwk"]').value = JSON.stringify({
Ägare

What's this hard-coded value for?

What's this hard-coded value for?
lastlink closed this pull request 2019-05-11 22:32:00 +00:00
Logga in för att delta i denna konversation.
Inga granskare
Ingen Etikett
Ingen Milsten
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: coolaj86/bluecrypt-keypairs.js#10
No description provided.