no-acme #10

已合併
lastlink 2019-05-11 22:32:00 +00:00 將 13 次代碼提交從 lastlink/bluecrypt-keypairs.js:no-acme 合併至 master
Collaborator
  • fixed merge issue
  • jwk to jwt & jws
* fixed merge issue * jwk to jwt & jws
coolaj86 approved these changes 2019-05-11 21:58:39 +00:00
coolaj86 left a comment
管理員

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?

Approving so this can merge, but will you PR again to remove the debug value for the key and use the generated key instead?
@ -52,3 +54,2 @@
kty: $('input[name="kty"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
, modulusLength: $('input[name="rsa-len"]:checked').value
, namedCurve: $('input[name="ec-crv"]:checked').value
管理員

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.

these aren't aligned. I wouldn't stop a merge for that, just want you to notice.
@ -112,1 +166,4 @@
$('.js-generate').hidden = false;
$('.js-sign').hidden = false;
$('textarea[name="jwk"]').value = JSON.stringify({
管理員

What's this hard-coded value for?

What's this hard-coded value for?
lastlink closed this pull request 2019-05-11 22:32:00 +00:00
登入 才能加入這對話。
No reviewers
未選擇標籤
未選擇里程碑
No Assignees
2 參與者
訊息
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/bluecrypt-keypairs.js#10
No description provided.