coolaj86/go-serviceman
2
2
Fork 0
Code Issues Pull Requests Releases Wiki Activity

path option #7

Closed
ryanburnette wants to merge 2 commits from (deleted):path into master
pull from: (deleted):path
merge into: coolaj86:master
Conversation 4 Commits 2 Files Changed 4 +34
ryanburnette commented 2019-07-17 15:23:59 +00:00
First-time contributor
Copy Link

Path option

  • add --path option to explicitly set path
  • update README.md

https://stackoverflow.com/questions/35439123/systemd-environment-directive-to-set-path
#6

Path option - [x] add `--path` option to explicitly set path - [x] update `README.md` https://stackoverflow.com/questions/35439123/systemd-environment-directive-to-set-path https://git.coolaj86.com/coolaj86/go-serviceman/issues/6
ryanburnette commented 2019-07-17 16:05:32 +00:00
Author
First-time contributor
Copy Link

Status

I'll know when I get back in a couple hours if the changes work. I believe before merging I should add comments and an example to README.md. @coolaj86 feedback?

Status I'll know when I get back in a couple hours if the changes work. I believe before merging I should add comments and an example to `README.md`. @coolaj86 feedback?
ryanburnette commented 2019-07-18 13:58:49 +00:00
Author
First-time contributor
Copy Link

@coolaj86 Take a look. If you're happy with the update to the lib and the readme then this is ready to merge.

I suggest doing a squashed merge because of my automatic commit messages.

@coolaj86 Take a look. If you're happy with the update to the lib and the readme then this is ready to merge. I suggest doing a squashed merge because of my automatic commit messages.
ryanburnette commented 2019-08-04 01:39:54 +00:00
Author
First-time contributor
Copy Link

@coolaj86 Thanks for helping me improve the PR today. We changed the --path option so it makes use of conf.Envs which was already implemented into the templates. That was a big improvement.

Ready to squash and merge.

@coolaj86 Thanks for helping me improve the PR today. We changed the `--path` option so it makes use of `conf.Envs` which was already implemented into the templates. That was a big improvement. Ready to squash and merge.
coolaj86 commented 2019-08-05 10:49:32 +00:00
Owner
Copy Link

Merged and published as v0.6.0

Once we get list and remove implemented I think I'll be happy to call this v1.0.0

Merged and published as v0.6.0 Once we get list and remove implemented I think I'll be happy to call this v1.0.0
coolaj86 closed this pull request 2019-08-05 10:49:32 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/go-serviceman#7
No description provided.
Delete Branch "(deleted):path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?