Remove doesn't set deletedAt on disk #1

Nouveau ticket

Ghost · 2021-04-09T10:37:38Z

Ghost a commenté

2021-04-09 10:37:38 +00:00

.

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.

I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: coolaj86/greenlock-manager-test.js#3

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening. I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3

Ghost a commenté

2021-04-09 11:29:03 +00:00

.

Auteur

Ahh, closing this as the bug is in Greenlock itself - documented here: coolaj86/greenlock.js#56

Issue regarding testing still stands afaict

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 Issue regarding testing still stands afaict

Ghost a fermé ce ticket

2021-04-09 11:29:03 +00:00

.

Connectez-vous pour rejoindre cette conversation.

1 participants

Notifications

Échéance

Aucune échéance n'a été définie.

Dépendances

Aucune dépendance définie.

Référence : coolaj86/greenlock-manager-fs.js#1