coolaj86
/
greenlock-manager-test.js
1
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

Test for remove() doesn't check either removal or that deletedAt() was set #3

New Issue
Open
opened 2021-04-09 10:35:29 +00:00 by Ghost · 1 comment
Ghost commented 2021-04-09 10:35:29 +00:00
Copy Link

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.
Ghost commented 2021-04-09 11:30:15 +00:00
Author
Copy Link

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when coolaj86/greenlock.js#56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
v3.1.1
v3.1.0
v3.0.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/greenlock-manager-test.js#3
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?