Test for remove() doesn't check either removal or that deletedAt() was set #3

Nova issue

Ghost · 2021-04-09T10:35:29Z

Ghost comentou

2021-04-09 10:35:29 +00:00

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.

Ghost referenciado esta issue de coolaj86/greenlock-manager-fs.js

2021-04-09 10:37:38 +00:00

Remove doesn't set deletedAt on disk #1

Ghost comentou

2021-04-09 11:30:15 +00:00

Autor

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when coolaj86/greenlock.js#56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.

Acesse para participar desta conversação.

1 participante(s)

Notificações

Data limite

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: coolaj86/greenlock-manager-test.js#3

Test for remove() doesn't check either removal or that deletedAt() was set #3

Test for `remove()` doesn't check either removal or that deletedAt() was set #3