Remove doesn't set deletedAt on disk #1
Štítky
Bez štítku
Bez milníku
Bez zpracovatelů
1 účastníků
Oznámení
Termín dokončení
Žádný termín dokončení.
Závislosti
Nejsou nastaveny žádné závislosti.
Reference: coolaj86/greenlock-manager-fs.js#1
Načítá se…
Odkázat v novém úkolu
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.
I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: coolaj86/greenlock-manager-test.js#3
Ahh, closing this as the bug is in Greenlock itself - documented here: coolaj86/greenlock.js#56
Issue regarding testing still stands afaict