coolaj86/greenlock-manager-fs.js
1
0
Forka 0
Codice Problemi Pull Requests Rilasci Wiki Attività

Remove doesn't set deletedAt on disk #1

Nuovo Problema
Chiuso
aperto 2021-04-09 10:37:38 +00:00 da Ghost · 1 comment
Ghost 2021-04-09 10:37:38 +00:00 ha commentato
Copia link

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.

I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: coolaj86/greenlock-manager-test.js#3

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening. I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ghost 2021-04-09 11:29:03 +00:00 ha commentato
Autore
Copia link

Ahh, closing this as the bug is in Greenlock itself - documented here: coolaj86/greenlock.js#56

Issue regarding testing still stands afaict

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 Issue regarding testing still stands afaict
Ghost chiuso questo probleam 2021-04-09 11:29:03 +00:00
Effettua l'accesso per partecipare alla conversazione.
Nessun Branch/Tag specificato
Rami (Branch) Tag
Etichette
Nessun elemento
Nessuna etichetta
Traguardo
Nessun elemento
Nessuna milestone
Assegnatari
Cancella assegnatari
coolaj86
Nessuna assegnatario
1 Partecipanti
Notifiche
Data di scadenza
Nessuna data di scadenza impostata.
Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/greenlock-manager-fs.js#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?