Etiķetes Atskaites punkti

Jauna problēma

Test for `remove()` doesn't check either removal or that deletedAt() was set #3

Atvērta

Ghost atvēra pirms 3 gadiem · 1 komentāri

Ghost komentēja pirms 3 gadiem

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.

Ghost atsaucās uz šo problēmu no coolaj86/greenlock-manager-fs.js pirms 3 gadiem

Remove doesn't set deletedAt on disk #1

Ghost komentēja pirms 3 gadiem

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.

Pierakstieties, lai pievienotos šai sarunai.

Nav norādīts atzars/tags

Atzari Tagi

master

v3.0.0

v3.1.0

v3.1.1

Etiķetes

Apstiprināt etiķetes

Noņemt etiķetes

Nav neviena ieraksta

Nav etiķešu

Atskaites punkts

Uzstādīt atskaites punktu

Notīrīt atskaites punktus

Nav neviena ieraksta

Nav atskaites punktu

Atbildīgie

Piešķirt lietotājus

Noņemt atbildīgo

Nav atbildīgo

1 dalībnieki

Paziņojumi

Abonēt

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Šai problēmai pagaidām nav nevienas atkarības.

Rakstīt Priekšskatītījums

Notiek ielāde…

Atcelt

Saglabāt

Vēl nav satura.