Test for remove() doesn't check either removal or that deletedAt() was set #3

Jauna problēma

Ghost · 2021-04-09T10:35:29Z

Ghost komentēja

2021-04-09 10:35:29 +00:00

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.

Ghost atsaucās uz šo problēmu no coolaj86/greenlock-manager-fs.js

2021-04-09 10:37:38 +00:00

Remove doesn't set deletedAt on disk #1

Ghost komentēja

2021-04-09 11:30:15 +00:00

Autors

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when coolaj86/greenlock.js#56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.

Nepieciešams pieteikties, lai pievienotos šai sarunai.

1 dalībnieki

Paziņojumi

Izpildes termiņš

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Atsaucas uz: coolaj86/greenlock-manager-test.js#3

Test for remove() doesn't check either removal or that deletedAt() was set #3

Test for `remove()` doesn't check either removal or that deletedAt() was set #3