Test for `remove()` doesn't check either removal or that deletedAt() was set #3
开启中
Ghost 创建于 3 年前
·
1 条评论
正在加载...
在新工单中引用
这个人很懒,什么都没留下。
删除分支 '%!s(MISSING)'
删除分支是永久的。此操作 无法 撤销,继续?
It seems like the call to
remove
should either fully remove the site entry, or at the very least setdeletedAt
to the current time.Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set
deletedAt
(at least in my own testing) - something that should be caught by the test suite.Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.
I'm still thinking that remove should be more fully tested.