v2.8.0: Fix regression with set challenges being ignored #40

coolaj86 · 2019-06-14T09:26:14Z

coolaj86

2019-06-14 09:26:14 +00:00

yorum yaptı

Sahibi

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.

coolaj86

2019-06-14 09:28:29 +00:00

değişiklik isteğini kapattı

coolaj86 başlığı ~~Fix regression with set challenges being ignored~~ iken v2.8.0: Fix regression with set challenges being ignored olarak 2019-06-14 09:28:58 +00:00 değiştirdi

coolaj86

2019-11-01 11:10:12 +00:00

işlemesinde bu konuyu işaret etti

Merge pull request #40 from Daplie/v2.x v2.x

Bu konuşmaya katılmak için oturum aç.

1 Katılımcı

Bildirimler

Bitiş Tarihi

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: coolaj86/greenlock.js-ARCHIVED#40