v2.8.0: Fix regression with set challenges being ignored #40

Manually merged
coolaj86 merged 1 commits from dns-challenge-regression-fix into master 2019-06-14 09:28:29 +00:00

1 Commits

Author SHA1 Message Date
AJ ONeal c8b895633c Fix regression with set challenges being ignored
Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available.  This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...
2019-06-14 03:21:03 -06:00