Etichette Traguardi

v2.8.0: Fix regression with set challenges being ignored #40

Unito manualmente

coolaj86 ha unito 1 commit da dns-challenge-regression-fix a master 5 anni fa

Conversazione 0 Commit 1 File modificati 4

coolaj86 5 anni fa ha commentato

Proprietario

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.

coolaj86 closed this pull request 5 anni fa

coolaj86 Titolo modificato da Fix regression with set challenges being ignored a v2.8.0: Fix regression with set challenges being ignored 5 anni fa

coolaj86 ha fatto riferimento a questa issue dal commit 5 anni fa

Merge pull request #40 from Daplie/v2.x v2.x

The pull request has been manually merged as c8b895633c.

Effettua l'accesso per partecipare alla conversazione.

Revisori

Richiedi revisione

Nessun revisore

Etichette

Applica etichette

Pulisci le etichette

Nessun elemento

Nessuna etichetta

Traguardo

Imposta traguardo

Milestone pulita

Nessun elemento

Nessuna milestone

Assegnatari

Assegna utenti

Cancella assegnatari

Nessuna assegnatario

1 Partecipanti

Notifiche

Iscriviti

Data di scadenza

La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

Scrivi Anteprima

Caricamento…

Annulla

Salva

Non ci sono ancora contenuti.