coolaj86/greenlock.js-ARCHIVED
3
3
Forka 0
Codice Problemi 6 Pull Requests 1 Rilasci Attività

v2.8.0: Fix regression with set challenges being ignored #40

Unito manualmente
coolaj86 ha unito 1 commit da dns-challenge-regression-fix a master 2019-06-14 09:28:29 +00:00
Conversazione 0 Commit 1 File modificati 4 +45 -24
coolaj86 2019-06-14 09:26:14 +00:00 ha commentato
Proprietario
Copia link

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.
coolaj86 chiusa questa pull request 2019-06-14 09:28:29 +00:00
coolaj86 Titolo modificato da Fix regression with set challenges being ignored a v2.8.0: Fix regression with set challenges being ignored 2019-06-14 09:28:58 +00:00
Effettua l'accesso per partecipare alla conversazione.
Revisori
No Reviewers
Etichette
Nessun elemento
Nessuna etichetta
Traguardo
Nessun elemento
Nessuna milestone
Assegnatari
Cancella assegnatari
jshaver coolaj86
Nessuna assegnatario
1 Partecipanti
Notifiche
Data di scadenza
Nessuna data di scadenza impostata.
Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/greenlock.js-ARCHIVED#40
No description provided.
Delete Branch "dns-challenge-regression-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?