coolaj86/greenlock.js-ARCHIVED
3
3
Vork 0
Code Kwesties 6 Pull-aanvragen 1 Publicaties Activiteit

v2.8.0: Fix regression with set challenges being ignored #40

Handmatig samengevoegd
coolaj86 heeft 1 commits samengevoegd van dns-challenge-regression-fix naar master 2019-06-14 09:28:29 +00:00
Discussie 0 Commits 1 Bestanden gewijzigd 4 +45 -24
coolaj86 reageerde 2019-06-14 09:26:14 +00:00
Eigenaar
Link kopiëren

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.
coolaj86 heeft deze pull request gesloten 2019-06-14 09:28:29 +00:00
coolaj86 titel aangepast van Fix regression with set challenges being ignored naar v2.8.0: Fix regression with set challenges being ignored 2019-06-14 09:28:58 +00:00
Log in om deel te nemen aan deze discussie.
Reviewers
No Reviewers
Labels
Geen items
Geen label
Mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Verwijder toegewezen aan
jshaver coolaj86
Niet toegewezen
1 deelnemers
Notificaties
Vervaldatum
Geen vervaldatum ingesteld.
Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: coolaj86/greenlock.js-ARCHIVED#40
No description provided.
Delete Branch "dns-challenge-regression-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?