v2.8.0: Fix regression with set challenges being ignored #40
Manually merged
coolaj86
heeft 1 commits samengevoegd van dns-challenge-regression-fix
naar master
5 jaren geleden
Laden…
Reference in new issue
Er is nog geen inhoud.
Verwijder branch 'dns-challenge-regression-fix'
Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?
Regression Fix
Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.
When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.
This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.
All this crap will be cleaned up in v3...
New Feature
Oh, and this adds support for
getZones()
, the testing of which brought about the need to fix the regression.Fix regression with set challenges being ignorednaar v2.8.0: Fix regression with set challenges being ignored 5 jaren geledenc8b895633c
.