v2.8.0: Fix regression with set challenges being ignored #40

手動合併
coolaj86 將 1 次代碼提交從 dns-challenge-regression-fix 合併至 master 5 年前
coolaj86 已留言 5 年前
擁有者

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.
coolaj86 關閉了這個合併請求 5 年前
coolaj86 將標題從 Fix regression with set challenges being ignored 改為 v2.8.0: Fix regression with set challenges being ignored 5 年前
此合併請求已被手動合併為 c8b895633c
登入 才能加入這對話。
沒有審核者
未選擇標籤
未選擇里程碑
沒有成員
1 參與者
通知
截止日期

未設定截止日期。

先決條件

此合併求目前沒有任何先決條件。

載入中…
尚未有任何內容