v2.8.0: Fix regression with set challenges being ignored #40

coolaj86 · 2019-06-14T09:26:14Z

coolaj86 已留言

2019-06-14 09:26:14 +00:00

擁有者

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.

coolaj86 關閉了這個合併請求

2019-06-14 09:28:29 +00:00

coolaj86 將標題從 ~~Fix regression with set challenges being ignored~~ 改為 v2.8.0: Fix regression with set challenges being ignored

2019-06-14 09:28:58 +00:00

coolaj86 在提交中關聯了這個問題

2019-11-01 11:10:12 +00:00

Merge pull request #40 from Daplie/v2.x v2.x

登入才能加入這對話。

1 參與者

通知

截止日期

未設定截止日期。

先決條件

未設定先決條件。

參考: coolaj86/greenlock.js-ARCHIVED#40