Labels Milestones

adding propagationDelay property to returned object in _normalizeChallenge #50

Merged

coolaj86 merged 1 commits from :add-propagationdelay into master 4 years ago

Conversation 2 Commits 1 Files Changed 1

Ghost commented 4 years ago

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object.

Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object. Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231

coolaj86 commented 4 years ago

Owner

I read the email first, now looking at this.

You are correct. I misunderstood.

I read the email first, now looking at this. You are correct. I misunderstood.

coolaj86 approved these changes 4 years ago

coolaj86 left a comment

Indeed, you are correct. Thank you!

coolaj86 merged commit 1a60d53c32 into master 4 years ago

coolaj86 commented 4 years ago

Owner

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

coolaj86 referenced this pull request 4 years ago

Don't forget to publish #51

Reviewers

coolaj86 approved these changes 4 years ago

The pull request has been merged as 1a60d53c32.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

coolaj86

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.