coolaj86
/
greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

adding propagationDelay property to returned object in _normalizeChallenge #50

Merged
coolaj86 merged 1 commits from :add-propagationdelay into master 2020-07-30 22:24:16 +00:00
Conversation 2 Commits 1 Files Changed 1 +4 -1
Ghost commented 2020-07-29 17:58:09 +00:00
First-time contributor
Copy Link

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object.

Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object. Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231
coolaj86 commented 2020-07-30 22:22:45 +00:00
Owner
Copy Link

I read the email first, now looking at this.

You are correct. I misunderstood.

I read the email first, now looking at this. You are correct. I misunderstood.
coolaj86 approved these changes 2020-07-30 22:24:02 +00:00
coolaj86 left a comment
Owner
Copy Link

Indeed, you are correct. Thank you!

Indeed, you are correct. Thank you!
coolaj86 merged commit 1a60d53c32 into master 2020-07-30 22:24:15 +00:00
coolaj86 commented 2020-07-30 22:24:43 +00:00
Owner
Copy Link

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.
Sign in to join this conversation.
Reviewers
No reviewers
coolaj86
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#50
No description provided.
Delete Branch ":add-propagationdelay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?