adding propagationDelay property to returned object in _normalizeChallenge #50

Merged
coolaj86 merged 1 commits from pmarashian/greenlock.js:add-propagationdelay into master 2 years ago

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object.

Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object. Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231
Owner

I read the email first, now looking at this.

You are correct. I misunderstood.

I read the email first, now looking at this. You are correct. I misunderstood.
coolaj86 approved these changes 2 years ago
coolaj86 left a comment

Indeed, you are correct. Thank you!

coolaj86 merged commit 1a60d53c32 into master 2 years ago
Owner

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

Reviewers

coolaj86 approved these changes 2 years ago
The pull request has been merged as 1a60d53c32.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.