adding propagationDelay property to returned object in _normalizeChallenge #50

Unito
coolaj86 ha unito 1 commit da :add-propagationdelay a master 4 anni fa
Ghost 4 anni fa ha commentato

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object.

Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object. Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231
coolaj86 4 anni fa ha commentato
Proprietario

I read the email first, now looking at this.

You are correct. I misunderstood.

I read the email first, now looking at this. You are correct. I misunderstood.
coolaj86 hanno approvato queste modifiche 4 anni fa
coolaj86 lascia un commento

Indeed, you are correct. Thank you!

coolaj86 merged commit 1a60d53c32 into master 4 anni fa
coolaj86 4 anni fa ha commentato
Proprietario

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

Revisori

coolaj86 hanno approvato queste modifiche 4 anni fa
La pull request è stata unita come 1a60d53c32.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna etichetta
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

Caricamento…
Non ci sono ancora contenuti.