coolaj86/greenlock.js-ARCHIVED
3
3
Forka 0
Codice Problemi 6 Pull Requests 1 Rilasci Attività

adding propagationDelay property to returned object in _normalizeChallenge #50

Unito
coolaj86 ha unito 1 commit da :add-propagationdelay a master 2020-07-30 22:24:16 +00:00
Conversazione 3 Commit 1 File modificati 1 +4 -1
Ghost 2020-07-29 17:58:09 +00:00 ha commentato
First-time contributor
Copia link

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object.

Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231

If you are using a custom dns-01 challenge the propagationDelay property is not included with the normalized challenger object. Acme/acme.js outputs a warning of this missing property at https://git.rootprojects.org/root/acme.js/src/branch/master/acme.js#L231
coolaj86 2020-07-30 22:22:45 +00:00 ha commentato
Proprietario
Copia link

I read the email first, now looking at this.

You are correct. I misunderstood.

I read the email first, now looking at this. You are correct. I misunderstood.
coolaj86 hanno approvato queste modifiche 2020-07-30 22:24:02 +00:00
coolaj86 lascia un commento
Proprietario
Copia link

Indeed, you are correct. Thank you!

Indeed, you are correct. Thank you!
coolaj86 merged commit 1a60d53c32 into master 2020-07-30 22:24:15 +00:00
coolaj86 2020-07-30 22:24:43 +00:00 ha commentato
Proprietario
Copia link

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.

I've got another bugfix that's waiting on some testing feedback and I'll publish this alongside that.
Effettua l'accesso per partecipare alla conversazione.
Revisori
No Reviewers
coolaj86
Etichette
Nessun elemento
Nessuna etichetta
Traguardo
Nessun elemento
Nessuna milestone
Assegnatari
Cancella assegnatari
jshaver coolaj86
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza
Nessuna data di scadenza impostata.
Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/greenlock.js-ARCHIVED#50
No description provided.
Delete Branch ":add-propagationdelay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?