1
0
Fork 0

Allow custom format for random values #3

Offen
Ghost möchte 2 Commits von (gelöscht):master nach master mergen
Erstmaliger Mitwirkender
Keine Beschreibung angegeben.
Ghost hat 1 Commit 2020-12-30 01:01:29 +00:00 hinzugefügt
Autor
Erstmaliger Mitwirkender

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.
Besitzer

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
Ghost hat 1 Commit 2021-01-02 17:14:02 +00:00 hinzugefügt
Autor
Erstmaliger Mitwirkender

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed
Autor
Erstmaliger Mitwirkender

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.
Autor
Erstmaliger Mitwirkender

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians
Besitzer

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)
Dieser Pull-Requests ist kaputt, da Fork-Informationen gelöscht wurden.
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Label
Kein Meilenstein
Niemand zuständig
2 Beteiligte
Nachrichten
Fällig am
Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: coolaj86/human-readable-ids.js#3
Keine Beschreibung angegeben.