coolaj86
/
human-readable-ids.js
1
0
Fork 0
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Allow custom format for random values #3

Open
Ghost wants to merge 2 commits from (deleted):master into master
pull from: (deleted):master
merge into: coolaj86:master
Conversation 6 Commits 2 Files Changed 3 +37 -4
Ghost commented 2020-12-30 01:01:28 +00:00
First-time contributor
Copy Link
No description provided.
Ghost added 1 commit 2020-12-30 01:01:29 +00:00
Ghost commented 2020-12-31 19:36:30 +00:00
Author
First-time contributor
Copy Link

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.
coolaj86 commented 2020-12-31 20:24:41 +00:00
Owner
Copy Link

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
Ghost added 1 commit 2021-01-02 17:14:02 +00:00
Ghost commented 2021-01-02 17:14:58 +00:00
Author
First-time contributor
Copy Link

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed
Ghost commented 2021-01-02 18:05:56 +00:00
Author
First-time contributor
Copy Link

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.
Ghost commented 2021-01-12 03:19:37 +00:00
Author
First-time contributor
Copy Link

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians
coolaj86 commented 2021-01-13 18:36:55 +00:00
Owner
Copy Link

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)
This pull request is broken due to missing fork information.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/human-readable-ids.js#3
No description provided.
Delete Branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?