coolaj86/human-readable-ids.js
1
0
Fork 0
Código Incidencias 2 Pull Requests 1 Lanzamientos Wiki Actividad

Allow custom format for random values #3

Abierta
Ghost desea fusionar 2 commits de (eliminado):master en master
recuperar de: (eliminado):master
fusionar en: coolaj86:master
Conversación 6 Commits 2 Archivos modificados 3 +37 -4
Ghost comentado 2020-12-30 01:01:28 +00:00
Contribuyente por primera vez
Copiar enlace
No se ha proporcionado una descripción.
Ghost añadido 1 commit 2020-12-30 01:01:29 +00:00
Ghost comentado 2020-12-31 19:36:30 +00:00
Autoría
Contribuyente por primera vez
Copiar enlace

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.
coolaj86 comentado 2020-12-31 20:24:41 +00:00
Propietario
Copiar enlace

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
Ghost añadido 1 commit 2021-01-02 17:14:02 +00:00
Ghost comentado 2021-01-02 17:14:58 +00:00
Autoría
Contribuyente por primera vez
Copiar enlace

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed
Ghost comentado 2021-01-02 18:05:56 +00:00
Autoría
Contribuyente por primera vez
Copiar enlace

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.
Ghost comentado 2021-01-12 03:19:37 +00:00
Autoría
Contribuyente por primera vez
Copiar enlace

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians
coolaj86 comentado 2021-01-13 18:36:55 +00:00
Propietario
Copiar enlace

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)
Este pull request está rota debido a que falta información del fork.
Inicie sesión para unirse a esta conversación.
Revisores
No Reviewers
Etiquetas
No hay elementos
Sin etiquetas
Milestone
No hay elementos
Sin Milestone
Asignados
Limpiar asignados
coolaj86
No asignados
2 participantes
Notificaciones
Fecha de vencimiento
Sin fecha de vencimiento.
Dependencias

No se han establecido dependencias.

Referencia: coolaj86/human-readable-ids.js#3
No se ha proporcionado una descripción.
Eliminar rama "(eliminado):master "

Eliminar una rama es permanente. Aunque la rama eliminada puede continuar existiendo durante un corto tiempo antes de que sea eliminada, en la mayoría de los casos NO PUEDE deshacerse. ¿Continuar?